Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: third_party/WebKit/Source/platform/heap/TraceTraits.h

Issue 2609383002: [wrapper-tracing] Simplify tracing and reduce technical debt (Closed)
Patch Set: Rebase on master after landing dep Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/TraceTraits.h
diff --git a/third_party/WebKit/Source/platform/heap/TraceTraits.h b/third_party/WebKit/Source/platform/heap/TraceTraits.h
index 15e97551e335e60f06311726aea9db1e4ab2233e..e2e31460594f8f65e41b28c5edfea579b1633e1c 100644
--- a/third_party/WebKit/Source/platform/heap/TraceTraits.h
+++ b/third_party/WebKit/Source/platform/heap/TraceTraits.h
@@ -188,7 +188,6 @@ class TraceTrait {
static void trace(Visitor*, void* self);
static void trace(InlinedGlobalMarkingVisitor, void* self);
- static void markAndTraceWrapper(const WrapperVisitor*, const void*);
static void markWrapperNoTracing(const WrapperVisitor*, const void*);
static void traceMarkedWrapper(const WrapperVisitor*, const void*);
static HeapObjectHeader* heapObjectHeader(const void*);
@@ -234,16 +233,6 @@ void TraceTrait<T>::trace(InlinedGlobalMarkingVisitor visitor, void* self) {
}
template <typename T>
-void TraceTrait<T>::markAndTraceWrapper(const WrapperVisitor* visitor,
- const void* t) {
- const T* traceable = ToWrapperTracingType(t);
- if (visitor->markWrapperHeader(heapObjectHeader(traceable))) {
- visitor->markWrappersInAllWorlds(traceable);
- visitor->dispatchTraceWrappers(traceable);
- }
-}
-
-template <typename T>
void TraceTrait<T>::markWrapperNoTracing(const WrapperVisitor* visitor,
const void* t) {
const T* traceable = ToWrapperTracingType(t);

Powered by Google App Engine
This is Rietveld 408576698