Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2609373002: [turbofan] Improve typing rules for NumberFloor and NumberDivide. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve typing rules for NumberFloor and NumberDivide. Also rule out -0 for NumberDivide if possible, and rule out NaN and -0 for NumberFloor if possible. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2609373002 Cr-Commit-Position: refs/heads/master@{#42059} Committed: https://chromium.googlesource.com/v8/v8/+/95db8643e1831918c6775d794dbaa3d9299613a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/compiler/operation-typer.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M src/compiler/type-cache.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-04 09:00:23 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-04 09:03:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609373002/1
3 years, 11 months ago (2017-01-04 09:04:44 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 09:25:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/95db8643e1831918c6775d794dbaa3d9299...

Powered by Google App Engine
This is Rietveld 408576698