DevTools: Remove left margin when DevTools is docked

DevTools: Remove left margin when DevTools is docked

BUG=678130
Review-Url: https://codereview.chromium.org/2609353002
Cr-Commit-Position: refs/heads/master@{#442489}
Committed: https://chromium.googlesource.com/chromium/src/+/fead49e2fd15801c992d66e9fd17642da17a0fbd

[einbinder, 2017-01-04 00:26:25]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2017-01-04 00:26:26]

ptal

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js
(right):

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js:30:
this._rootSplitWidget = new UI.SplitWidget(false, true,
'InspectorView.splitViewState', 555, 300, true, 10);
There is a click area of 5px, down from 6px.

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js (right):

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js:40: * @param
{number=} resizerThickness
Adding yet another parameter feels unfortunate.

[dgozman, 2017-01-04 18:11:22]

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/emulation/InspectedPagePlaceholder.js
(left):

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/emulation/InspectedPagePlaceholder.js:29:
margins[side] = Emulation.InspectedPagePlaceholder.MarginValue;
Remove everything about margins from this file now.

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js (right):

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js:40: * @param
{number=} resizerThickness
On 2017/01/04 00:26:26, einbinder wrote:
> Adding yet another parameter feels unfortunate. 

Turn it into a setter.

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js:63: if
(isVertical)
Note that isVertical may change (see setVertical).

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js:66:
this._resizerElement.style.width = resizerThickness + 'px';
This makes it extra-thick in device mode, right?

I'd just craft some css to translate(?) the resizer of one specific split
widget.

[einbinder, 2017-01-05 20:41:00]

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/emulation/InspectedPagePlaceholder.js
(left):

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/emulation/InspectedPagePlaceholder.js:29:
margins[side] = Emulation.InspectedPagePlaceholder.MarginValue;
On 2017/01/04 at 18:11:22, dgozman_slow wrote:
> Remove everything about margins from this file now.

Done.

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js (right):

https://codereview.chromium.org/2609353002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js:66:
this._resizerElement.style.width = resizerThickness + 'px';
On 2017/01/04 at 18:11:22, dgozman_slow wrote:
> This makes it extra-thick in device mode, right?
> 
> I'd just craft some css to translate(?) the resizer of one specific split
widget.

Done.

[einbinder, 2017-01-05 20:41:04]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 20:41:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 23:08:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 23:08:27]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-01-10 00:45:54]

lgtm

[einbinder, 2017-01-10 00:48:09]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:49:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 02:52:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 02:52:07]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)

[einbinder, 2017-01-10 03:56:55]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:57:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 05:01:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484020615533460,
"parent_rev": "f5157480667e99269e0062e9df1df3875db85197", "commit_rev":
"fead49e2fd15801c992d66e9fd17642da17a0fbd"}

[commit-bot: I haz the power, 2017-01-10 05:01:33]

Description was changed from

==========
DevTools: Remove left margin when DevTools is docked

BUG=678130
==========

to

==========
DevTools: Remove left margin when DevTools is docked

BUG=678130

Review-Url: https://codereview.chromium.org/2609353002
Cr-Commit-Position: refs/heads/master@{#442489}
Committed:
https://chromium.googlesource.com/chromium/src/+/fead49e2fd15801c992d66e9fd17...
==========

[commit-bot: I haz the power, 2017-01-10 05:01:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fead49e2fd15801c992d66e9fd17...