Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2609313002: Revert of Android accessibility: automatically focus links (Closed)

Created:
3 years, 11 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 11 months ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android accessibility: automatically focus links (patchset #3 id:40001 of https://codereview.chromium.org/2465403003/ ) Reason for revert: Caused scrolling bug http://crbug.com/675567 BUG=657157, 675567 Original issue's description: > Android accessibility: automatically focus links > > When setting accessibility focus to a node, auto-focus it if it's a link. > This is needed for some sites that have skip links that are only visible > when focused. It might be possible to auto-focus more than just links but > this seems the safest. > > Fixing this exposed a race condition with our code to refocus the node with > accessibility focus if its location has changed - essentially when you > click on the skip link, the skip link was changing its location, causing us > to fire notifications on it because its location had changed - but that > was racing with the real change to accessibility focus from following the > skip link. > > Fix this race condition by re-focusing the node with accessibility focus > after a short delay, and canceling the delayed task if accessibility > focus changes again. > > Tested manually with two urls that exercise these code paths. > > BUG=657157 > TESTED=http://getbootstrap.com/ and http://jsfiddle.net/mev0c4dt/show/ > > Committed: https://crrev.com/fd9566093da77d9413ba61f8be1b6e03daaadf33 > Cr-Commit-Position: refs/heads/master@{#430006} TBR=dtseng@chromium.org,sgurun@chromium.org,dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=657157 Committed: https://crrev.com/12c8f43c72337a88c60abaa36a9b0e8adbba9453 Cr-Commit-Position: refs/heads/master@{#441248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -73 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 7 chunks +7 lines, -68 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
aelias_OOO_until_Jul13
Created Revert of Android accessibility: automatically focus links
3 years, 11 months ago (2017-01-03 22:43:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609313002/1
3 years, 11 months ago (2017-01-03 22:43:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 23:24:03 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 23:28:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12c8f43c72337a88c60abaa36a9b0e8adbba9453
Cr-Commit-Position: refs/heads/master@{#441248}

Powered by Google App Engine
This is Rietveld 408576698