Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2609243002: DevTools: Preserve the selection across shadow DOM in StylesSideBar (Closed)

Created:
3 years, 11 months ago by einbinder
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Preserve the selection across shadow DOM in StylesSideBar If a selection crossed between shadow roots, it wouldn't be detected and a new blank property would be added on mouse up. The last patch about this was missing a vital exclamation point. BUG=654163 Committed: https://crrev.com/80e1ad7ddfbd24068d09c367521aaddd46bd7e25 Cr-Commit-Position: refs/heads/master@{#441251}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
einbinder
ptal
3 years, 11 months ago (2017-01-03 20:04:51 UTC) #3
dgozman
lgtm
3 years, 11 months ago (2017-01-03 21:31:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609243002/20001
3 years, 11 months ago (2017-01-03 21:31:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 23:28:34 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 23:31:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80e1ad7ddfbd24068d09c367521aaddd46bd7e25
Cr-Commit-Position: refs/heads/master@{#441251}

Powered by Google App Engine
This is Rietveld 408576698