Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2609233003: Fix context menu "Copy image" not working sometimes at hidpi. (Closed)

Created:
3 years, 11 months ago by Bret
Modified:
3 years, 11 months ago
Reviewers:
esprehn
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix context menu "Copy image" not working sometimes at hidpi. Coordinate conversion was happening from viewport->window when opening the context menu, but not the other direction when asking to copy an image. Also fixes the same issue when using "Download image" on a <canvas> (using "Download image" on an <img> uses a different codepath). R=esprehn@chromium.org TEST=Right-click the top-left corner of an image and select "Copy image" with dsf>1. The image should be copied correctly. BUG=667223 Review-Url: https://codereview.chromium.org/2541423003 Cr-Commit-Position: refs/heads/master@{#439966} (cherry picked from commit 9e97b2c8a89e7a89003906b5e11a30a6260a4099) Committed: https://chromium.googlesource.com/chromium/src/+/8e2afdfc4f366d9b010f10ad058fa1e072f037e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Bret
3 years, 11 months ago (2017-01-03 23:48:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e2afdfc4f366d9b010f10ad058fa1e072f037e7.

Powered by Google App Engine
This is Rietveld 408576698