Fix context menu "Copy image" not working sometimes at hidpi.

Fix context menu "Copy image" not working sometimes at hidpi.

Coordinate conversion was happening from viewport->window when opening
the context menu, but not the other direction when asking to copy an
image. Also fixes the same issue when using "Download image" on a
<canvas> (using "Download image" on an <img> uses a different codepath).

R=esprehn@chromium.org
TEST=Right-click the top-left corner of an image and select "Copy image"
     with dsf>1. The image should be copied correctly.
BUG=667223
Committed: https://crrev.com/9e97b2c8a89e7a89003906b5e11a30a6260a4099
Cr-Commit-Position: refs/heads/master@{#439966}

[esprehn, 2016-12-01 20:29:37]

Can we get a unit test?

[Bret, 2016-12-07 22:15:30]

On 2016/12/01 20:29:37, esprehn wrote:
> Can we get a unit test?

Sorry for the delayed response.

I took a stab at writing a test for this and it's been difficult. There's no
unit test for RenderFrameImpl currently. There's a browser test, but that means
all its dependencies are real so I'm not sure how to check that the coordinates
are being transformed. I tried to make a fake version of WebLocalFrame but since
that's a WebKit class I'm running into disallowed dependencies. Unless you have
a way to resolve this I don't think a test is forthcoming...

[esprehn, 2016-12-08 02:20:24]

esprehn@chromium.org changed reviewers:
+ chrishtr@chromium.org

[esprehn, 2016-12-08 02:20:24]

Could you write a test like this one?
https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl_brows...

lgtm if there really is no way to test this. chrishtr@ knows more about the
conversion functions here so you might want to make sure you used it right.

[chrishtr, 2016-12-09 18:32:16]

lgtm

[Bret, 2016-12-20 22:44:17]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:45:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 01:30:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482273857865830, "parent_rev":
"24a547cf88c11f8299075ec56c0edb07a6fcc982", "commit_rev":
"697d4f6c20a049d6c6b9fa31260904bdbdfa6191"}

[commit-bot: I haz the power, 2016-12-21 01:31:05]

Description was changed from

==========
Fix context menu "Copy image" not working sometimes at hidpi.

Coordinate conversion was happening from viewport->window when opening
the context menu, but not the other direction when asking to copy an
image. Also fixes the same issue when using "Download image" on a
<canvas> (using "Download image" on an <img> uses a different codepath).

R=esprehn@chromium.org
TEST=Right-click the top-left corner of an image and select "Copy image"
     with dsf>1. The image should be copied correctly.
BUG=667223
==========

to

==========
Fix context menu "Copy image" not working sometimes at hidpi.

Coordinate conversion was happening from viewport->window when opening
the context menu, but not the other direction when asking to copy an
image. Also fixes the same issue when using "Download image" on a
<canvas> (using "Download image" on an <img> uses a different codepath).

R=esprehn@chromium.org
TEST=Right-click the top-left corner of an image and select "Copy image"
     with dsf>1. The image should be copied correctly.
BUG=667223

Review-Url: https://codereview.chromium.org/2541423003
==========

[commit-bot: I haz the power, 2016-12-21 01:31:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 01:34:46]

Description was changed from

==========
Fix context menu "Copy image" not working sometimes at hidpi.

Coordinate conversion was happening from viewport->window when opening
the context menu, but not the other direction when asking to copy an
image. Also fixes the same issue when using "Download image" on a
<canvas> (using "Download image" on an <img> uses a different codepath).

R=esprehn@chromium.org
TEST=Right-click the top-left corner of an image and select "Copy image"
     with dsf>1. The image should be copied correctly.
BUG=667223

Review-Url: https://codereview.chromium.org/2541423003
==========

to

==========
Fix context menu "Copy image" not working sometimes at hidpi.

Coordinate conversion was happening from viewport->window when opening
the context menu, but not the other direction when asking to copy an
image. Also fixes the same issue when using "Download image" on a
<canvas> (using "Download image" on an <img> uses a different codepath).

R=esprehn@chromium.org
TEST=Right-click the top-left corner of an image and select "Copy image"
     with dsf>1. The image should be copied correctly.
BUG=667223

Committed: https://crrev.com/9e97b2c8a89e7a89003906b5e11a30a6260a4099
Cr-Commit-Position: refs/heads/master@{#439966}
==========

[commit-bot: I haz the power, 2016-12-21 01:34:47]

Patchset 1 (id:??) landed as
https://crrev.com/9e97b2c8a89e7a89003906b5e11a30a6260a4099
Cr-Commit-Position: refs/heads/master@{#439966}