Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: components/signin/core/browser/signin_status_metrics_provider.cc

Issue 2609213002: SigninStatusMetricsProvider factory returns a std::unique_ptr<>. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_status_metrics_provider.cc
diff --git a/components/signin/core/browser/signin_status_metrics_provider.cc b/components/signin/core/browser/signin_status_metrics_provider.cc
index 04d54fa8a7f7cc9f3c2325b0db6e19c21a554d0f..699e61d6190f361b9c7aa1174de1906d7639aaf4 100644
--- a/components/signin/core/browser/signin_status_metrics_provider.cc
+++ b/components/signin/core/browser/signin_status_metrics_provider.cc
@@ -8,6 +8,7 @@
#include "base/bind.h"
#include "base/location.h"
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
@@ -45,9 +46,11 @@ void SigninStatusMetricsProvider::ProvideGeneralMetrics(
}
// static
-SigninStatusMetricsProvider* SigninStatusMetricsProvider::CreateInstance(
+std::unique_ptr<SigninStatusMetricsProvider>
+SigninStatusMetricsProvider::CreateInstance(
std::unique_ptr<SigninStatusMetricsProviderDelegate> delegate) {
- return new SigninStatusMetricsProvider(std::move(delegate), false);
+ return base::WrapUnique(
+ new SigninStatusMetricsProvider(std::move(delegate), false));
}
void SigninStatusMetricsProvider::OnSigninManagerCreated(

Powered by Google App Engine
This is Rietveld 408576698