Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2609193002: Skip mjsunit/big-object-literal for debug builds. (Closed)

Created:
3 years, 11 months ago by vogelheim
Modified:
3 years, 11 months ago
CC:
Franzi, Michael Achenbach, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip mjsunit/big-object-literal for debug builds. mjsunit/big-object-literal will exhaust the stack in debug builds, due to different compiler settings. It will work in optdebug. This disables for both. Adding an 'optdebug' test to .status files is easy, but I don't want to contribute to the 'mode x variant explosion'. R=jochen@chromium.org CC=franzih@chromium.org, machenbach@chromium.org Review-Url: https://codereview.chromium.org/2609193002 Cr-Commit-Position: refs/heads/master@{#42061} Committed: https://chromium.googlesource.com/v8/v8/+/ffa4010cc861318e5aefd5952ecd7396e241f412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
vogelheim
Per our offline discussion... is this acceptable, absent a proper fix for the issue?
3 years, 11 months ago (2017-01-03 14:44:10 UTC) #5
jochen (gone - plz use gerrit)
adding adamk for his opinion
3 years, 11 months ago (2017-01-03 15:53:47 UTC) #9
adamk
This lgtm. This test is super-old, I'm not sure how relevant it is at this ...
3 years, 11 months ago (2017-01-03 18:46:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609193002/20001
3 years, 11 months ago (2017-01-04 09:59:07 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 10:00:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ffa4010cc861318e5aefd5952ecd7396e24...

Powered by Google App Engine
This is Rietveld 408576698