Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2609173005: [V8] Run clang-tidy performance-for-range-copy check on src/ (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[V8] Run clang-tidy performance-for-range-copy check on src/ BUG=None Review-Url: https://codereview.chromium.org/2609173005 Cr-Commit-Position: refs/heads/master@{#42094} Committed: https://chromium.googlesource.com/v8/v8/+/2804502615939981c9f1b0397969c293886c6499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/compilation-statistics.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/libplatform/tracing/trace-config.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Devlin
for funzies.
3 years, 11 months ago (2017-01-04 20:15:58 UTC) #6
adamk
lgtm, but you'll need a compiler/ OWNER for some of this stuff. Also no need ...
3 years, 11 months ago (2017-01-04 20:39:26 UTC) #8
Benedikt Meurer
LGTM on compiler
3 years, 11 months ago (2017-01-05 04:50:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609173005/1
3 years, 11 months ago (2017-01-05 16:00:17 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 16:02:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2804502615939981c9f1b0397969c293886...

Powered by Google App Engine
This is Rietveld 408576698