Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2609153002: [ic] Use StrictEqual/Equal builtins for CompareIC slow path. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Use StrictEqual/Equal builtins for CompareIC slow path. Don't fallback to the %StrictEqual / %Equal runtime functions for the generic CompareIC slow path, but use the (new) StrictEqual and Equal builtins instead. This avoids a performance cliff when mixing input types for strict equality sites. R=jochen@chromium.org BUG=v8:4773 Review-Url: https://codereview.chromium.org/2609153002 Cr-Commit-Position: refs/heads/master@{#42021} Committed: https://chromium.googlesource.com/v8/v8/+/d3ed71ed87426046afe8938592588eeaa92ec7a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-03 08:05:37 UTC) #1
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-03 08:14:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609153002/1
3 years, 11 months ago (2017-01-03 08:15:18 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 08:30:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d3ed71ed87426046afe8938592588eeaa92...

Powered by Google App Engine
This is Rietveld 408576698