Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2609113004: Fix a crash when downloading a dangerous download (Closed)

Created:
3 years, 11 months ago by qinmin
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash when downloading a dangerous download When downloading a dangerous download, Chrome should show an infobar in current tab. However, the java side only checks the filename for dangerous download. As a result, in some cases it may close a blank tab even if the download is dangerous. That causes the download to be removed and cause a crash when returning to the caller. BUG=667215 Committed: https://crrev.com/abc63973a87249b44623b0744c2efdf9c6bbfa5c Cr-Commit-Position: refs/heads/master@{#441266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 3 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/android/download/chrome_download_delegate.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/android/download/download_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
qinmin
PTAL
3 years, 11 months ago (2017-01-03 23:01:13 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 11 months ago (2017-01-03 23:26:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609113004/1
3 years, 11 months ago (2017-01-03 23:54:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 00:27:57 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 00:30:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abc63973a87249b44623b0744c2efdf9c6bbfa5c
Cr-Commit-Position: refs/heads/master@{#441266}

Powered by Google App Engine
This is Rietveld 408576698