PaymentApp: Add PaymentAppProvider class.

content/browser/payments/payment_app_content_unittest_base.h

Index: content/browser/payments/payment_app_content_unittest_base.h
diff --git a/content/browser/payments/payment_app_content_unittest_base.h b/content/browser/payments/payment_app_content_unittest_base.h
index 3e4413a2784363f36add910a21b445f91c6ef0b7..726f06e14fa4d41661718721749864c8959fab01 100644
--- a/content/browser/payments/payment_app_content_unittest_base.h
+++ b/content/browser/payments/payment_app_content_unittest_base.h
@@ -18,6 +18,7 @@
 
 namespace content {
 
+class BrowserContext;
 class EmbeddedWorkerTestHelper;
 class PaymentAppContextImpl;
 class StoragePartitionImpl;
@@ -28,9 +29,7 @@ class PaymentAppContentUnitTestBase : public testing::Test {
   PaymentAppContentUnitTestBase();
   ~PaymentAppContentUnitTestBase() override;
 
-  PaymentAppContextImpl* payment_app_context() const {
-    return payment_app_context_.get();
-  }
+  BrowserContext* browser_context();
   PaymentAppManager* CreatePaymentAppManager(const GURL& scope_url,
                                              const GURL& sw_script_url);
   void SetManifest(PaymentAppManager* manager,
@@ -45,8 +44,8 @@ class PaymentAppContentUnitTestBase : public testing::Test {
  private:
   std::unique_ptr<TestBrowserThreadBundle> thread_bundle_;
   std::unique_ptr<EmbeddedWorkerTestHelper> embedded_worker_helper_;
-  std::unique_ptr<StoragePartitionImpl> storage_partition_impl_;
-  scoped_refptr<PaymentAppContextImpl> payment_app_context_;
+  StoragePartitionImpl* storage_partition_impl_;

[please use gerrit instead, 2017/01/04 16:55:43]

Here and below:

Raw pointers lead to memory errors and are discouraged. If you must use raw
pointers, add comments explaining ownership and lifetime of these member
variables.

[zino, 2017/01/04 17:29:59]

The pointers is owned by BrowserContext and it manages their lifetime.
I left these variables to access each object easily but it wasn't a good way.
Instead I added two getter methods and then used them.

Done.

+  PaymentAppContextImpl* payment_app_context_;
   std::vector<payments::mojom::PaymentAppManagerPtr> payment_app_managers_;
 
   DISALLOW_COPY_AND_ASSIGN(PaymentAppContentUnitTestBase);