PaymentApp: Add PaymentAppProvider class.

content/browser/payments/payment_app_content_unittest_base.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_PAYMENTS_PAYMENT_APP_CONTENT_UNITTEST_BASE_H_
 #define CONTENT_BROWSER_PAYMENTS_PAYMENT_APP_CONTENT_UNITTEST_BASE_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "components/payments/payment_app.mojom.h"
 #include "content/browser/payments/payment_app_manager.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 namespace content {
 
+class BrowserContext;
 class EmbeddedWorkerTestHelper;
 class PaymentAppContextImpl;
 class StoragePartitionImpl;
 class TestBrowserThreadBundle;
 
 class PaymentAppContentUnitTestBase : public testing::Test {
  protected:
   PaymentAppContentUnitTestBase();
   ~PaymentAppContentUnitTestBase() override;
 
-  PaymentAppContextImpl* payment_app_context() const {
-    return payment_app_context_.get();
-  }
+  BrowserContext* browser_context();
   PaymentAppManager* CreatePaymentAppManager(const GURL& scope_url,
                                              const GURL& sw_script_url);
   void SetManifest(PaymentAppManager* manager,
                    payments::mojom::PaymentAppManifestPtr manifest,
                    const PaymentAppManager::SetManifestCallback& callback);
   void GetManifest(PaymentAppManager* manager,
                    const PaymentAppManager::GetManifestCallback& callback);
   payments::mojom::PaymentAppManifestPtr CreatePaymentAppManifestForTest(
       const std::string& name);
   void UnregisterServiceWorker(const GURL& scope_url);
 
  private:
   std::unique_ptr<TestBrowserThreadBundle> thread_bundle_;
   std::unique_ptr<EmbeddedWorkerTestHelper> embedded_worker_helper_;
-  std::unique_ptr<StoragePartitionImpl> storage_partition_impl_;
-  scoped_refptr<PaymentAppContextImpl> payment_app_context_;
+  StoragePartitionImpl* storage_partition_impl_;

[please use gerrit instead, 2017/01/04 16:55:43]

Here and below:

Raw pointers lead to memory errors and are discouraged. If you must use raw
pointers, add comments explaining ownership and lifetime of these member
variables.

[zino, 2017/01/04 17:29:59]

The pointers is owned by BrowserContext and it manages their lifetime.
I left these variables to access each object easily but it wasn't a good way.
Instead I added two getter methods and then used them.

Done.

+  PaymentAppContextImpl* payment_app_context_;
   std::vector<payments::mojom::PaymentAppManagerPtr> payment_app_managers_;
 
   DISALLOW_COPY_AND_ASSIGN(PaymentAppContentUnitTestBase);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_PAYMENTS_PAYMENT_APP_CONTENT_UNITTEST_BASE_H_