Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2609093002: Revert of Use consistent types for ICC profiles (Closed)

Created:
3 years, 11 months ago by engedy
Modified:
3 years, 11 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, einbinder+watch-test-runner_chromium.org, f(malita), jam, jbroman, jochen+watch_chromium.org, Justin Novosad, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use consistent types for ICC profiles (patchset #5 id:80001 of https://codereview.chromium.org/2605743002/ ) Reason for revert: Rebaselining not possible due to discrepancy between test outputs produced by continuous builders vs. try jobs. See crbug.com/677822 for details. Speculatively reverting this CL as it has to do with ICC profiles and I am mostly seeing differences of color shades in pixel diffs. Original issue's description: > Use consistent types for ICC profiles > > In Blink we convert from a gfx::ICCProfile to a raw vector of data. > Stop doing this, and, instead, pass the gfx::ICCProfile (or its gfx::ColorSpace > or SkColorSpace, as appropriate). > > Merge several locations where we store ICC profiles for testing > into ui/gfx/test/icc_profiles. > > BUG=634102 > TBR=esprehn > > Committed: https://crrev.com/0b283e725b6489c7be426f1958419d19e8b348b7 > Cr-Commit-Position: refs/heads/master@{#441004} TBR=chrishtr@chromium.org,avi@chromium.org,esprehn@chromium.org,ccameron@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=634102, 677822 Committed: https://crrev.com/8d0ed9b51268dc2265f3fdf5c9a3b330d9a8a529 Cr-Commit-Position: refs/heads/master@{#441078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+974 lines, -612 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_widget.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +17 lines, -4 lines 0 comments Download
M content/renderer/render_widget_owner_delegate.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/layouttest_support.cc View 3 chunks +545 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorBehavior.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp View 3 chunks +59 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M ui/gfx/color_space.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/color_space.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/color_transform_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/gfx/icc_profile_unittest.h View 1 chunk +10 lines, -0 lines 0 comments Download
M ui/gfx/icc_profile_unittest.cc View 1 chunk +308 lines, -1 line 0 comments Download
D ui/gfx/test/icc_profiles.h View 1 chunk +0 lines, -14 lines 0 comments Download
D ui/gfx/test/icc_profiles.cc View 1 chunk +0 lines, -545 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
engedy
Created Revert of Use consistent types for ICC profiles
3 years, 11 months ago (2017-01-02 16:59:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609093002/1
3 years, 11 months ago (2017-01-02 17:00:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609093002/1
3 years, 11 months ago (2017-01-02 17:00:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609093002/1
3 years, 11 months ago (2017-01-02 17:51:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-02 20:06:24 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 20:08:56 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d0ed9b51268dc2265f3fdf5c9a3b330d9a8a529
Cr-Commit-Position: refs/heads/master@{#441078}

Powered by Google App Engine
This is Rietveld 408576698