Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2609023002: Check editing status before doing actions. (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
Reviewers:
gambard
CC:
chromium-reviews, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check editing status before doing actions. Mode switching is animated so buttons can be pressed after mode was switched. Check the editing mode and cancel action if editing mode is off. BUG=677777 Committed: https://crrev.com/22b65df274844b3a459a8dd02cce8f8eaa655a7f Cr-Commit-Position: refs/heads/master@{#441054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm View 5 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Olivier
3 years, 11 months ago (2017-01-02 09:52:25 UTC) #2
gambard
lgtm
3 years, 11 months ago (2017-01-02 09:56:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609023002/1
3 years, 11 months ago (2017-01-02 10:01:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-02 10:11:38 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:55:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22b65df274844b3a459a8dd02cce8f8eaa655a7f
Cr-Commit-Position: refs/heads/master@{#441054}

Powered by Google App Engine
This is Rietveld 408576698