Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2609003003: WindowAnimationWorklet: gracefully handle detached use (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, haraken, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WindowAnimationWorklet: gracefully handle detached use BUG=677605 Committed: https://crrev.com/09ccdd3b967bc2d7679da7a5de1dd2eec7a61a59 Cr-Commit-Position: refs/heads/master@{#441096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
haraken
PTAL A similar fix to https://codereview.chromium.org/2607353002/
3 years, 11 months ago (2017-01-03 01:37:53 UTC) #2
sof
lgtm; thanks, i incorrectly dup-classified the 677605 stack.
3 years, 11 months ago (2017-01-03 06:15:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609003003/1
3 years, 11 months ago (2017-01-03 06:15:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 07:52:45 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 07:54:30 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/09ccdd3b967bc2d7679da7a5de1dd2eec7a61a59
Cr-Commit-Position: refs/heads/master@{#441096}

Powered by Google App Engine
This is Rietveld 408576698