Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2608933002: Remove ThreadState::callThreadShutdownHooks() declaration. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ThreadState::callThreadShutdownHooks() declaration. No longer provided and used. R= BUG= Committed: https://crrev.com/6261f75b1701b3db68fe22ca09bf77e160538d6c Cr-Commit-Position: refs/heads/master@{#441041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/platform/heap/GCInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sof
please take a look. Let's round out 2016 with a difficult one :)
3 years, 11 months ago (2016-12-31 12:52:35 UTC) #4
haraken
LGTM
3 years, 11 months ago (2016-12-31 12:53:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608933002/1
3 years, 11 months ago (2016-12-31 14:17:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-31 14:26:28 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:54:49 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6261f75b1701b3db68fe22ca09bf77e160538d6c
Cr-Commit-Position: refs/heads/master@{#441041}

Powered by Google App Engine
This is Rietveld 408576698