Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2608843002: [promsies] Verify status field is a smi (Closed)

Created:
3 years, 11 months ago by gsathya
Modified:
3 years, 11 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promsies] Verify status field is a smi R=adamk@chromium.org BUG=v8:5343 Review-Url: https://codereview.chromium.org/2608843002 Cr-Commit-Position: refs/heads/master@{#41997} Committed: https://chromium.googlesource.com/v8/v8/+/2d46f50771c337f3d8aeaf0c7cc049064dda5e34

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
gsathya
3 years, 11 months ago (2016-12-30 01:18:39 UTC) #7
adamk
lgtm, but it seems like AllocateJSPromise is an easy-to-misuse API if it gives you back ...
3 years, 11 months ago (2016-12-30 01:26:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608843002/20001
3 years, 11 months ago (2016-12-30 01:49:10 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2016-12-30 01:50:55 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2d46f50771c337f3d8aeaf0c7cc049064dd...

Powered by Google App Engine
This is Rietveld 408576698