third_party/WebKit/Source/platform/text/Character.cpp - Issue 2608823002: Move blink::serializedCharacterData array to read-only data segment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/Character.cpp

Issue 2608823002: Move blink::serializedCharacterData array to read-only data segment (Closed)

Patch Set: Might as well mark serializedCharacterDataSize as const also Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/Character.cpp

diff --git a/third_party/WebKit/Source/platform/text/Character.cpp b/third_party/WebKit/Source/platform/text/Character.cpp

index f4b0bf536950eff898d9e53d9b9d31b62c037b57..57fe4e7392836c01072c27b77657aab9adf21f08 100644

--- a/third_party/WebKit/Source/platform/text/Character.cpp

+++ b/third_party/WebKit/Source/platform/text/Character.cpp

@@ -75,8 +75,8 @@ static icu::UnicodeSet* createUnicodeSet(const UChar32* characters,

return unicodeSet->contains(c);

#else

// Freezed trie tree, see CharacterDataGenerator.cpp.

-extern int32_t serializedCharacterDataSize;

-extern uint8_t serializedCharacterData[];

+extern const int32_t serializedCharacterDataSize;

+extern const uint8_t serializedCharacterData[];

static UTrie2* createTrie() {

// Create a Trie from the value array.

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/text/CharacterPropertyDataGenerator.cpp » ('j') | no next file with comments »