Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2608793002: DevTools: Fix storage handler host-setting (Closed)

Created:
3 years, 11 months ago by phulce
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix storage handler host-setting Fixes issue where clearDataForOrigin returned InternalError. BUG=677545 Committed: https://crrev.com/b2320b5dcc4882ca28f9211b141c03843c07a17d Cr-Commit-Position: refs/heads/master@{#440986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/devtools/protocol/storage_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/storage_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
phulce
3 years, 11 months ago (2016-12-29 20:28:35 UTC) #3
dgozman
lgtm. Thanks for the fix!
3 years, 11 months ago (2016-12-29 20:38:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608793002/1
3 years, 11 months ago (2016-12-29 20:43:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 21:45:53 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:53:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2320b5dcc4882ca28f9211b141c03843c07a17d
Cr-Commit-Position: refs/heads/master@{#440986}

Powered by Google App Engine
This is Rietveld 408576698