Making scripts for getting Android Chromium compatible with Ubuntu 16.10 Yakkety

Supporting Ubuntu 16.10 in scripts for getting Android Chromium

Committed: https://crrev.com/73929a70f66473ab4be0f6431721b1728b3db019
Cr-Commit-Position: refs/heads/master@{#441479}

[marcin, 2016-12-30 01:16:54]

Description was changed from

==========
Merge branch 'master' of https://chromium.googlesource.com/chromium/src into
build1610


Add author


Patch for Ubuntu 16.10

BUG=
==========

to

==========
Change fixes scripts and allows for getting Android Chromium on Ubuntu 16.10
==========

[marcin, 2016-12-30 01:16:54]

marcin@mwiacek.com changed reviewers:
+ jochen@chromium.org

[marcin, 2016-12-30 01:19:46]

Description was changed from

==========
Change fixes scripts and allows for getting Android Chromium on Ubuntu 16.10
==========

to

==========
Change is making scripts for getting Android Chromium compatible with Ubuntu
16.10 Yakkety
==========

[marcin, 2016-12-30 01:31:07]

The CQ bit was checked by marcin@mwiacek.com

[marcin, 2016-12-30 01:31:10]

The CQ bit was unchecked by marcin@mwiacek.com

[marcin, 2016-12-30 01:31:13]

The CQ bit was checked by marcin@mwiacek.com

[marcin, 2016-12-30 01:31:16]

The CQ bit was unchecked by marcin@mwiacek.com

[marcin, 2016-12-30 01:31:18]

The CQ bit was checked by marcin@mwiacek.com

[commit-bot: I haz the power, 2016-12-30 01:31:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-30 01:31:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-30 01:31:23]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[jochen (gone - plz use gerrit), 2017-01-02 07:48:01]

jochen@chromium.org changed reviewers:
+ dpranke@chromium.org, jbudorick@chromium.org

[jochen (gone - plz use gerrit), 2017-01-02 07:48:02]

thanks for submitting the patch! I checked the CLA, and looks good!

could you please format the commit message to be < 80c (following git
conventions, see also
http://dev.chromium.org/developers/contributing-code#TOC-Writing-change-list-...)

Adding reviewers that might be better suited for those changes.

[marcin, 2017-01-02 08:12:17]

On 2017/01/02 07:48:02, jochen wrote:
> thanks for submitting the patch! I checked the CLA, and looks good!
> 
> could you please format the commit message to be < 80c (following git
> conventions, see also
>
http://dev.chromium.org/developers/contributing-code#TOC-Writing-change-list-...)
> 
> Adding reviewers that might be better suited for those changes.

Thank you.

It looks, that formatting is already done (longest line seems to have
76 chars).

[marcin, 2017-01-02 08:26:16]

On 2017/01/02 08:12:17, marcin wrote:
> On 2017/01/02 07:48:02, jochen wrote:
> > thanks for submitting the patch! I checked the CLA, and looks good!
> > 
> > could you please format the commit message to be < 80c (following git
> > conventions, see also
> >
>
http://dev.chromium.org/developers/contributing-code#TOC-Writing-change-list-...)
> > 
> > Adding reviewers that might be better suited for those changes.
> 
> Thank you.
> 
> It looks, that formatting is already done (longest line seems to have
> 76 chars).

I have updated info message too, please review.

[jochen (gone - plz use gerrit), 2017-01-02 08:32:35]

hum, the only line of the CL description is 90 characters.

It should be at most 80. Also, please don't just wrap the CL description, but
make sure the first line is a summary, so git log --pretty=oneline will read
nicely.

[jochen (gone - plz use gerrit), 2017-01-02 08:33:24]

btw, you have to change the CL description on this website - doing so locally
won't work, sorry

there's an edit button that lets you modify the CL description

[marcin, 2017-01-02 08:36:06]

Description was changed from

==========
Change is making scripts for getting Android Chromium compatible with Ubuntu
16.10 Yakkety
==========

to

==========
Update scripts for getting Android Chromium for Ubuntu 16.10
==========

[marcin, 2017-01-02 08:37:22]

On 2017/01/02 08:33:24, jochen wrote:
> btw, you have to change the CL description on this website - doing so locally
> won't work, sorry
> 
> there's an edit button that lets you modify the CL description

hmmm, I'm sorry for the problem (you're right)

I have changed description, please review, thank you

[marcin, 2017-01-02 08:38:35]

Description was changed from

==========
Update scripts for getting Android Chromium for Ubuntu 16.10
==========

to

==========
Supporting Ubuntu 16.10 in scripts for getting Android Chromium
==========

[jochen (gone - plz use gerrit), 2017-01-02 10:40:37]

I defer for the actual review to dpranke/jbudorikc

[jbudorick, 2017-01-03 13:39:18]

https://codereview.chromium.org/2608733005/diff/20001/build/install-build-dep...
File build/install-build-deps-android.sh (right):

https://codereview.chromium.org/2608733005/diff/20001/build/install-build-dep...
build/install-build-deps-android.sh:25: xenial)
Can this just be

  xenial|yakkety)

?

[Dirk Pranke, 2017-01-04 02:41:13]

lgtm w/ jbudorick's comment address.

thomasanderson: fyi

[Tom (Use chromium acct), 2017-01-04 03:32:45]

thomasanderson@google.com changed reviewers:
+ thomasanderson@google.com

[Tom (Use chromium acct), 2017-01-04 03:32:46]

https://codereview.chromium.org/2608733005/diff/20001/build/install-build-dep...
File build/install-build-deps.sh (right):

https://codereview.chromium.org/2608733005/diff/20001/build/install-build-dep...
build/install-build-deps.sh:239: wily)
looks like the wily, xenial, and yakkety branches are all the same.  Could you
condense them into one?

[marcin, 2017-01-04 21:18:10]

On 2017/01/04 03:32:46, Tom Anderson wrote:
>
https://codereview.chromium.org/2608733005/diff/20001/build/install-build-dep...
> File build/install-build-deps.sh (right):
> 
>
https://codereview.chromium.org/2608733005/diff/20001/build/install-build-dep...
> build/install-build-deps.sh:239: wily)
> looks like the wily, xenial, and yakkety branches are all the same.  Could you
> condense them into one?

I have created 3rd patch set. Could you review it now please ?

[Tom (Use chromium acct), 2017-01-04 21:22:50]

lgtm

[jbudorick, 2017-01-04 21:26:28]

lgtm

[marcin, 2017-01-04 21:35:11]

The CQ bit was checked by marcin@mwiacek.com

[marcin, 2017-01-04 21:35:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2608733005/#ps40001
(title: "Support Ubuntu 16.10 in scripts for getting Android Chromium")

[commit-bot: I haz the power, 2017-01-04 21:35:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:05:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483565711334610,
"parent_rev": "b76e435a5da47daeb6266d0d5f8f277fb4226a3b", "commit_rev":
"e89ced5ddfb93b4d36e9bb204389e08138a61408"}

[commit-bot: I haz the power, 2017-01-04 22:05:34]

Description was changed from

==========
Supporting Ubuntu 16.10 in scripts for getting Android Chromium
==========

to

==========
Supporting Ubuntu 16.10 in scripts for getting Android Chromium

Review-Url: https://codereview.chromium.org/2608733005
==========

[commit-bot: I haz the power, 2017-01-04 22:05:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-04 22:08:10]

Description was changed from

==========
Supporting Ubuntu 16.10 in scripts for getting Android Chromium

Review-Url: https://codereview.chromium.org/2608733005
==========

to

==========
Supporting Ubuntu 16.10 in scripts for getting Android Chromium

Committed: https://crrev.com/73929a70f66473ab4be0f6431721b1728b3db019
Cr-Commit-Position: refs/heads/master@{#441479}
==========

[commit-bot: I haz the power, 2017-01-04 22:08:11]

Patchset 3 (id:??) landed as
https://crrev.com/73929a70f66473ab4be0f6431721b1728b3db019
Cr-Commit-Position: refs/heads/master@{#441479}