Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2608733003: Check GetVisibleItem exists in GetFormattedURL (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check GetVisibleItem exists in GetFormattedURL When Clearing Presented state, it is possible that no Visible item exists. Check before dereferencing. Fix cl/2606873002 BUG=674986 Committed: https://crrev.com/ec9390684f586181f0d50334c20e99dc05333b3b Cr-Commit-Position: refs/heads/master@{#440957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ui/toolbar/toolbar_model_impl_ios.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Olivier
PTAL
3 years, 11 months ago (2016-12-29 15:14:56 UTC) #2
marq (ping after 24h)
lgtm
3 years, 11 months ago (2016-12-29 15:32:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608733003/1
3 years, 11 months ago (2016-12-29 15:34:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 15:50:26 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec9390684f586181f0d50334c20e99dc05333b3b
Cr-Commit-Position: refs/heads/master@{#440957}

Powered by Google App Engine
This is Rietveld 408576698