Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2608733002: Fix include/import in ios/testing and ios/chrome/test (Closed)

Created:
3 years, 11 months ago by Olivier
Modified:
3 years, 11 months ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, pkl (ping after 24h if needed), nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, noyau+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix include/import in ios/testing and ios/chrome/test include -> import +#import "base/ios/block_types.h" +#import "base/mac/bind_objc_block.h" +#import "base/mac/scoped_nsobject.h" +#import "base/test/ios/wait_util.h" +#import "ios/chrome/app/application_delegate/metrics_mediator.h" +#import "ios/chrome/app/application_delegate/metrics_mediator_testing.h" +#import "ios/chrome/browser/signin/authentication_service.h" +#import "ios/chrome/browser/ui/uikit_ui_util.h" +#import "ios/chrome/test/app/histogram_test_util.h" +#import "ios/chrome/test/app/history_test_util.h" +#import "ios/chrome/test/base/perf_test_ios.h" +#import "ios/chrome/test/block_cleanup_test.h" +#import "ios/chrome/test/ocmock/scoped_mock_object.h" +#import "ios/public/provider/chrome/browser/chrome_browser_provider.h" +#import "ios/web/public/web_client.h" +#import "ios/web/public/web_state/web_state.h" +#import "testing/gtest_mac.h" +#import <Foundation/Foundation.h> import -> include +#include "ios/chrome/test/app/bookmarks_test_util.h" +#include "ios/chrome/test/app/settings_test_util.h" +#include "ios/chrome/test/base/scoped_block_swizzler.h" +#include "ios/chrome/test/earl_grey/accessibility_util.h" +#include "ios/chrome/test/earl_grey/chrome_util.h" Committed: https://crrev.com/3c03c1c3c15b831a1743e1456e542390eb49cc55 Cr-Commit-Position: refs/heads/master@{#440965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -41 lines) Patch
M ios/chrome/test/app/bookmarks_test_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/app/chrome_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/app/chrome_test_util.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/test/app/histogram_test_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/app/history_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/app/history_test_util.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/test/app/settings_test_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/app/signin_test_util.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/test/app/sync_test_util.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/test/base/perf_test_ios.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/base/perf_test_ios.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/base/scoped_block_swizzler.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/base/scoped_block_swizzler_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/test/block_cleanup_test.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/test/earl_grey/accessibility_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/earl_grey/chrome_earl_grey.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/earl_grey/chrome_matchers.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/earl_grey/chrome_test_case.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/earl_grey/chrome_test_case.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/earl_grey/chrome_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/google_toolbox_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/ios_chrome_unit_test_suite.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/test/ocmock/scoped_mock_object.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/ocmock/scoped_verifying_mock_object.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/testing_application_context.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/testing/earl_grey/disabled_test_macros.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/testing/ocmock_complex_type_helper.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/testing/ocmock_complex_type_helper_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/testing/wait_util.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/testing/wait_util.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Olivier
3 years, 11 months ago (2016-12-29 14:53:33 UTC) #2
marq (ping after 24h)
lgtm
3 years, 11 months ago (2016-12-29 15:12:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608733002/1
3 years, 11 months ago (2016-12-29 17:22:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 17:35:51 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:33 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3c03c1c3c15b831a1743e1456e542390eb49cc55
Cr-Commit-Position: refs/heads/master@{#440965}

Powered by Google App Engine
This is Rietveld 408576698