Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2608713002: [NTP::RecentTabs] Context menu: show only "Remove". (Closed)

Created:
3 years, 11 months ago by vitaliii
Modified:
3 years, 11 months ago
Reviewers:
dgn
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP::RecentTabs] Context menu: show only "Remove". Show only "Remove" in recent (open) tab context menu. All other context menu items make no sense for this section. BUG=674892 Committed: https://crrev.com/f20d7c954ace31673bc63845eb65798b52c333e2 Cr-Commit-Position: refs/heads/master@{#441027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
vitaliii
[small (5 lines) CL] Hi dgn@, Could you have a look?
3 years, 11 months ago (2016-12-29 10:44:49 UTC) #2
dgn
lgtm
3 years, 11 months ago (2016-12-30 11:56:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608713002/1
3 years, 11 months ago (2016-12-30 11:57:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-30 12:30:53 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:54:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f20d7c954ace31673bc63845eb65798b52c333e2
Cr-Commit-Position: refs/heads/master@{#441027}

Powered by Google App Engine
This is Rietveld 408576698