Fix: Factor iOS native image loading into a utility function.

Fix: Factor iOS native image loading into a utility function.

[ToolsMenuViewToolsCell imageForImageId:] checked that id was not-zero.
Current implementation DCHECKS.
Add tests.
This is a follow up of https://codereview.chromium.org/2602903002/

TBR=marq

Committed: https://crrev.com/6f744e69aed7cb03be7bc578aa4859a43d2ef269
Cr-Commit-Position: refs/heads/master@{#440946}

[Olivier, 2016-12-29 08:41:07]

Description was changed from

==========
Fix: Factor iOS native image loading into a utility function.

[ToolsMenuViewToolsCell imageForImageId:] checked that id was not-zero.
Current implementation DCHECKS.
Add tests.
This is a follow up of https://codereview.chromium.org/2602903002/
==========

to

==========
Fix: Factor iOS native image loading into a utility function.

[ToolsMenuViewToolsCell imageForImageId:] checked that id was not-zero.
Current implementation DCHECKS.
Add tests.
This is a follow up of https://codereview.chromium.org/2602903002/

TBR=marq
==========

[Olivier, 2016-12-29 08:41:07]

olivierrobin@chromium.org changed reviewers:
+ marq@chromium.org

[Olivier, 2016-12-29 08:41:31]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2016-12-29 08:41:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 08:53:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483000891737110, "parent_rev":
"3b415601ed170d730d97e9591d599d7e1c8e9d6c", "commit_rev":
"6de08f6e202477a50925ec29e55df6e7b9036cc5"}

[commit-bot: I haz the power, 2016-12-29 08:54:06]

Description was changed from

==========
Fix: Factor iOS native image loading into a utility function.

[ToolsMenuViewToolsCell imageForImageId:] checked that id was not-zero.
Current implementation DCHECKS.
Add tests.
This is a follow up of https://codereview.chromium.org/2602903002/

TBR=marq
==========

to

==========
Fix: Factor iOS native image loading into a utility function.

[ToolsMenuViewToolsCell imageForImageId:] checked that id was not-zero.
Current implementation DCHECKS.
Add tests.
This is a follow up of https://codereview.chromium.org/2602903002/

TBR=marq

Review-Url: https://codereview.chromium.org/2608693002
==========

[commit-bot: I haz the power, 2016-12-29 08:54:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:51:58]

Description was changed from

==========
Fix: Factor iOS native image loading into a utility function.

[ToolsMenuViewToolsCell imageForImageId:] checked that id was not-zero.
Current implementation DCHECKS.
Add tests.
This is a follow up of https://codereview.chromium.org/2602903002/

TBR=marq

Review-Url: https://codereview.chromium.org/2608693002
==========

to

==========
Fix: Factor iOS native image loading into a utility function.

[ToolsMenuViewToolsCell imageForImageId:] checked that id was not-zero.
Current implementation DCHECKS.
Add tests.
This is a follow up of https://codereview.chromium.org/2602903002/

TBR=marq

Committed: https://crrev.com/6f744e69aed7cb03be7bc578aa4859a43d2ef269
Cr-Commit-Position: refs/heads/master@{#440946}
==========

[commit-bot: I haz the power, 2017-01-02 15:51:59]

Patchset 1 (id:??) landed as
https://crrev.com/6f744e69aed7cb03be7bc578aa4859a43d2ef269
Cr-Commit-Position: refs/heads/master@{#440946}