Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2608683002: [stubs] Remove dead IncStub and DecStub (Closed)

Created:
3 years, 11 months ago by danno
Modified:
3 years, 11 months ago
Reviewers:
mvstanton, rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -311 lines) Patch
M src/code-factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +0 lines, -277 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +264 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
danno
PTAL
3 years, 11 months ago (2016-12-29 08:33:39 UTC) #3
mvstanton
lgtm
3 years, 11 months ago (2016-12-29 09:02:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608683002/1
3 years, 11 months ago (2016-12-29 09:03:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/21ebbd3ec257a1c87da08cfd89cf5f418c9f2587
3 years, 11 months ago (2016-12-29 09:05:05 UTC) #11
rmcilroy
3 years, 11 months ago (2017-01-03 09:32:08 UTC) #13
Message was sent while issue was closed.
I guess this is just a straight copy from code-stub-assembler to interpreter, if
so LGTM (although the CL title / description is a bit unclear). LGTM

Powered by Google App Engine
This is Rietveld 408576698