Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2608613002: Followup cleanup from the removal of base::ScopedPtrHashMap from device/. (Closed)

Created:
3 years, 11 months ago by Avi (use Gerrit)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Followup cleanup from the removal of base::ScopedPtrHashMap from device/. BUG=579229 Committed: https://crrev.com/ead6f06f2776deaeabda862b183237217abf0815 Cr-Commit-Position: refs/heads/master@{#440930}

Patch Set 1 #

Patch Set 2 : fixed reversal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M device/bluetooth/bluetooth_device_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_android.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Avi (use Gerrit)
Officially waiting until the trybots go green, but the followup you requested.
3 years, 11 months ago (2016-12-29 00:05:42 UTC) #4
Reilly Grant (use Gerrit)
lgtm
3 years, 11 months ago (2016-12-29 00:19:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608613002/1
3 years, 11 months ago (2016-12-29 00:38:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/92266)
3 years, 11 months ago (2016-12-29 01:04:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608613002/20001
3 years, 11 months ago (2016-12-29 01:10:56 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-29 02:59:39 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:34 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ead6f06f2776deaeabda862b183237217abf0815
Cr-Commit-Position: refs/heads/master@{#440930}

Powered by Google App Engine
This is Rietveld 408576698