Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2608603002: Reland "Tab (and AuraWindow) Capture: Capture refresh frame after Resume()" (Closed)

Created:
3 years, 11 months ago by miu
Modified:
3 years, 11 months ago
Reviewers:
xjz
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Tab (and AuraWindow) Capture: Capture refresh frame after Resume()" Root cause was due to a shutdown race condition. Rather than resolve that, it was easier to simply remove some mostly-dead code paths that are no longer needed (https://codereview.chromium.org/2605973002/). Original review: https://codereview.chromium.org/2603533002/ BUG=643964 CQ-DEPEND=CL:2605973002 Committed: https://crrev.com/5740fa8801d59cfd99bac735ef483f1360e11492 Cr-Commit-Position: refs/heads/master@{#441319}

Patch Set 1 : Original patch #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M content/browser/media/capture/aura_window_capture_machine.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
xjz
lgtm
3 years, 11 months ago (2017-01-03 17:53:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608603002/1
3 years, 11 months ago (2017-01-03 17:53:40 UTC) #5
miu
On 2017/01/03 17:53:40, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 11 months ago (2017-01-03 18:35:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608603002/20001
3 years, 11 months ago (2017-01-04 03:57:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 04:55:42 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 04:57:38 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5740fa8801d59cfd99bac735ef483f1360e11492
Cr-Commit-Position: refs/heads/master@{#441319}

Powered by Google App Engine
This is Rietveld 408576698