Remove some dead code for operating on headers-as-a-string.

Remove some dead code for operating on headers-as-a-string.

New code should be using HttpRequestHeaders or HttpResponseHeaders,
as appropriate.

BUG=none

Committed: https://crrev.com/d1ce8d1e4550551a76709b3acf7a2fbb357ba349
Cr-Commit-Position: refs/heads/master@{#440931}

[mmenke, 2016-12-28 20:44:46]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 20:44:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-12-28 21:38:42]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2016-12-28 21:38:43]

Death to dead code!

This still leaves in HasHeader, and AppendHeaderIfMissing. 
AppendHeaderIfMissing has one consumer (...Which passes in an empty original
header string) and uses HasHeader, but I think tfarina may work on fixing that. 
If not, I'll eventually get to it.

[commit-bot: I haz the power, 2016-12-28 21:46:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 21:46:50]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-12-29 01:15:28]

lgtm

https://codereview.chromium.org/2608563002/diff/1/net/http/http_util.h
File net/http/http_util.h (right):

https://codereview.chromium.org/2608563002/diff/1/net/http/http_util.h#newcode49
net/http/http_util.h:49: // Parses the value of a "Range" header as defined in
RFC 7233 Secion 2.1.
typo: Section

[mmenke, 2016-12-29 02:14:28]

Thanks!

https://codereview.chromium.org/2608563002/diff/1/net/http/http_util.h
File net/http/http_util.h (right):

https://codereview.chromium.org/2608563002/diff/1/net/http/http_util.h#newcode49
net/http/http_util.h:49: // Parses the value of a "Range" header as defined in
RFC 7233 Secion 2.1.
On 2016/12/29 01:15:28, eroman (slow) wrote:
> typo: Section

Done.

[mmenke, 2016-12-29 02:14:46]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-12-29 02:14:47]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2608563002/#ps20001
(title: "Fix typo")

[commit-bot: I haz the power, 2016-12-29 02:14:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 03:07:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482977686898030,
"parent_rev": "50501471e3493f852869025043b1b81d7614936e", "commit_rev":
"4058d98bd564c4145027fc1094640fd16678ee75"}

[commit-bot: I haz the power, 2016-12-29 03:07:32]

Description was changed from

==========
Remove some dead code for operating on headers-as-a-string.

New code should be using HttpRequestHeaders or HttpResponseHeaders,
as appropriate.

BUG=none
==========

to

==========
Remove some dead code for operating on headers-as-a-string.

New code should be using HttpRequestHeaders or HttpResponseHeaders,
as appropriate.

BUG=none

Review-Url: https://codereview.chromium.org/2608563002
==========

[commit-bot: I haz the power, 2016-12-29 03:07:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-02 15:51:35]

Description was changed from

==========
Remove some dead code for operating on headers-as-a-string.

New code should be using HttpRequestHeaders or HttpResponseHeaders,
as appropriate.

BUG=none

Review-Url: https://codereview.chromium.org/2608563002
==========

to

==========
Remove some dead code for operating on headers-as-a-string.

New code should be using HttpRequestHeaders or HttpResponseHeaders,
as appropriate.

BUG=none

Committed: https://crrev.com/d1ce8d1e4550551a76709b3acf7a2fbb357ba349
Cr-Commit-Position: refs/heads/master@{#440931}
==========

[commit-bot: I haz the power, 2017-01-02 15:51:35]

Patchset 2 (id:??) landed as
https://crrev.com/d1ce8d1e4550551a76709b3acf7a2fbb357ba349
Cr-Commit-Position: refs/heads/master@{#440931}