Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2608473002: Revert of Pass origin as a parameter to PaymentApp#getInstruments (Closed)

Created:
3 years, 12 months ago by Walter Cacau
Modified:
3 years, 12 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass origin as a parameter to PaymentApp#getInstruments (patchset #4 id:60001 of https://codereview.chromium.org/2565143002/ ) Reason for revert: Need to revert temporarily to sort out some internal build breakages. Will attempt reland after Original issue's description: > Pass origin as a parameter to PaymentApp#getInstruments > > This will be needed by new changes to some of the existing PaymentApp > implementations. > > BUG=674369 > > Review-Url: https://codereview.chromium.org/2565143002 TBR=rouslan@chromium.org,loums@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=674369

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
Walter Cacau
Created Revert of Pass origin as a parameter to PaymentApp#getInstruments
3 years, 12 months ago (2016-12-27 22:00:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608473002/1
3 years, 12 months ago (2016-12-27 22:00:58 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 12 months ago (2016-12-27 22:01:01 UTC) #5
please use gerrit instead
lgtm
3 years, 12 months ago (2016-12-27 22:08:41 UTC) #6
Walter Cacau
3 years, 12 months ago (2016-12-28 01:23:58 UTC) #8
Message was sent while issue was closed.
On 2016/12/27 22:08:41, rouslan-intermittent-holidays wrote:
> lgtm

didn't actually need to land this revert in order to fix the build, so just
closed it

Powered by Google App Engine
This is Rietveld 408576698