Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2565143002: Pass origin as a parameter to PaymentApp#getInstruments (Closed)

Created:
4 years ago by Walter Cacau
Modified:
3 years, 11 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass origin as a parameter to PaymentApp#getInstruments This will be needed by new changes to some of the existing PaymentApp implementations. BUG=674369 Committed: https://crrev.com/a619d17dc53f2582ecb9d5d73dd0d5f86873b385 Cr-Commit-Position: refs/heads/master@{#440786}

Patch Set 1 #

Patch Set 2 : Pass origin as a parameter to PaymentApp#getInstruments #

Patch Set 3 : Pass origin as a parameter to PaymentApp#getInstruments #

Patch Set 4 : rebasing #

Messages

Total messages: 36 (28 generated)
Walter Cacau
4 years ago (2016-12-10 07:43:30 UTC) #4
please use gerrit instead
1) Please make sure that at least one payment app is using the new parameter ...
4 years ago (2016-12-12 14:34:37 UTC) #12
Walter Cacau
On 2016/12/12 14:34:37, rouslan wrote: > 1) Please make sure that at least one payment ...
4 years ago (2016-12-15 02:25:40 UTC) #14
please use gerrit instead
LGTM. Land this in immediately before the patch that uses the new param.
4 years ago (2016-12-16 20:54:44 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565143002/60001
3 years, 12 months ago (2016-12-27 20:20:12 UTC) #30
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 12 months ago (2016-12-27 20:54:39 UTC) #33
Walter Cacau
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2608473002/ by waltercacau@chromium.org. ...
3 years, 12 months ago (2016-12-27 22:00:49 UTC) #34
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:07 UTC) #36
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a619d17dc53f2582ecb9d5d73dd0d5f86873b385
Cr-Commit-Position: refs/heads/master@{#440786}

Powered by Google App Engine
This is Rietveld 408576698