Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2608453002: Remove the password parameter for ECPrivateKey::ExportEncryptedPrivateKey. (Closed)

Created:
4 years, 2 months ago by davidben
Modified:
4 years, 2 months ago
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, cbentzel+watch_chromium.org, zea+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the password parameter for ECPrivateKey::ExportEncryptedPrivateKey. Even with a password, the encryption scheme used here is really not what we'd want people to use. This does two things: 1. Cut down on the number of ways to use ExportEncryptedPrivateKey and makes it less likely someone will mistakenly use it for security purposes. 2. When we ported to BoringSSL, we added "raw" versions of PKCS8_{encrypt,decrypt} to account for confusion about two ways to encode the empty password. But PKCS8_{encrypt,decrypt} already handled this by treating NULL and "" differently. Limiting to just the empty password lets us trim BoringSSL's API surface in preparation for decoupling it from crypto/asn1. BUG=603319 Committed: https://crrev.com/1c02c94c34e1c57154914d51c44e818aa290f7a0 Cr-Commit-Position: refs/heads/master@{#441365}

Patch Set 1 #

Patch Set 2 : fmt #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -95 lines) Patch
M components/gcm_driver/crypto/p256_key_util.cc View 2 chunks +1 line, -3 lines 0 comments Download
M crypto/ec_private_key.h View 1 2 chunks +4 lines, -9 lines 0 comments Download
M crypto/ec_private_key.cc View 4 chunks +11 lines, -21 lines 0 comments Download
M crypto/ec_private_key_unittest.cc View 6 chunks +3 lines, -37 lines 0 comments Download
M crypto/ec_signature_creator_unittest.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M net/extras/sqlite/sqlite_channel_id_store.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/extras/sqlite/sqlite_channel_id_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ssl/channel_id_service.h View 1 chunk +0 lines, -5 lines 1 comment Download
M net/ssl/channel_id_service.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/ssl/ssl_platform_key_nss_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (16 generated)
davidben
https://codereview.chromium.org/2608453002/diff/20001/net/ssl/channel_id_service.h File net/ssl/channel_id_service.h (left): https://codereview.chromium.org/2608453002/diff/20001/net/ssl/channel_id_service.h#oldcode75 net/ssl/channel_id_service.h:75: static const char kEPKIPassword[]; I'm assuming we don't have ...
4 years, 2 months ago (2016-12-28 03:22:26 UTC) #8
Ryan Sleevi
lgtm
4 years, 2 months ago (2016-12-28 08:03:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608453002/20001
4 years, 2 months ago (2016-12-28 08:03:38 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/332920)
4 years, 2 months ago (2016-12-28 08:09:29 UTC) #15
davidben
+peter for components/gcm_driver
4 years, 2 months ago (2016-12-28 21:19:01 UTC) #17
Peter Beverloo
lgtm
4 years, 2 months ago (2017-01-04 12:55:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608453002/20001
4 years, 2 months ago (2017-01-04 12:55:20 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2017-01-04 13:55:04 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2017-01-04 13:57:12 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c02c94c34e1c57154914d51c44e818aa290f7a0
Cr-Commit-Position: refs/heads/master@{#441365}

Powered by Google App Engine
This is Rietveld 408576698