[csa] Re-introduce automatic constant folding for IntPtrAdd and IntPtrSub

[csa] Re-introduce automatic constant folding for IntPtrAdd and IntPtrSub

R=ishell@chromium.org
LOG=N

Review-Url: https://codereview.chromium.org/2608433003
Cr-Commit-Position: refs/heads/master@{#41977}
Committed: https://chromium.googlesource.com/v8/v8/+/743b89768c3caea1aaca2e25c9058cbdec1e0019

[danno, 2016-12-28 15:43:01]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 15:43:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-12-28 15:43:26]

ptal

[Igor Sheludko, 2016-12-28 15:57:05]

lgtm with nits:

https://codereview.chromium.org/2608433003/diff/40001/src/compiler/code-assem...
File src/compiler/code-assembler.cc (right):

https://codereview.chromium.org/2608433003/diff/40001/src/compiler/code-assem...
src/compiler/code-assembler.cc:284: if (sum >=
std::numeric_limits<int32_t>::min() &&
I think we can always return the sum.

https://codereview.chromium.org/2608433003/diff/40001/src/compiler/code-assem...
src/compiler/code-assembler.cc:308: if (diff >=
std::numeric_limits<int32_t>::min() &&
Same here.

[danno, 2016-12-28 16:04:44]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 16:04:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-12-28 16:05:33]

thanks! feedback addressed, landing

https://codereview.chromium.org/2608433003/diff/40001/src/compiler/code-assem...
File src/compiler/code-assembler.cc (right):

https://codereview.chromium.org/2608433003/diff/40001/src/compiler/code-assem...
src/compiler/code-assembler.cc:284: if (sum >=
std::numeric_limits<int32_t>::min() &&
On 2016/12/28 15:57:05, Igor Sheludko wrote:
> I think we can always return the sum.

Done.

https://codereview.chromium.org/2608433003/diff/40001/src/compiler/code-assem...
src/compiler/code-assembler.cc:308: if (diff >=
std::numeric_limits<int32_t>::min() &&
On 2016/12/28 15:57:05, Igor Sheludko wrote:
> Same here.

Done.

[commit-bot: I haz the power, 2016-12-28 16:30:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 16:30:45]

Dry run: This issue passed the CQ dry run.

[danno, 2016-12-28 16:36:36]

The CQ bit was checked by danno@chromium.org

[danno, 2016-12-28 16:36:36]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2608433003/#ps60001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-12-28 16:36:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 16:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 16:39:49]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31394)

[danno, 2016-12-28 16:55:36]

danno@chromium.org changed reviewers:
+ epertoso@chromium.org

[danno, 2016-12-28 16:55:36]

ptal for owner

[epertoso, 2016-12-28 16:57:03]

lgtm

[danno, 2016-12-28 16:57:24]

The CQ bit was checked by danno@chromium.org

[commit-bot: I haz the power, 2016-12-28 16:57:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 16:59:04]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482944244662540,
"parent_rev": "81df56ae5f65d3dac37a8c1fd76a90b77c3504d5", "commit_rev":
"743b89768c3caea1aaca2e25c9058cbdec1e0019"}

[commit-bot: I haz the power, 2016-12-28 16:59:11]

Description was changed from

==========
[csa] Re-introduce automatic constant folding for IntPtrAdd and IntPtrSub

R=ishell@chromium.org
LOG=N
==========

to

==========
[csa] Re-introduce automatic constant folding for IntPtrAdd and IntPtrSub

R=ishell@chromium.org
LOG=N

Review-Url: https://codereview.chromium.org/2608433003
Cr-Commit-Position: refs/heads/master@{#41977}
Committed:
https://chromium.googlesource.com/v8/v8/+/743b89768c3caea1aaca2e25c9058cbdec1...
==========

[commit-bot: I haz the power, 2016-12-28 16:59:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/743b89768c3caea1aaca2e25c9058cbdec1...