Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2608433002: Fix SealHandleScope usage in runtime calls (Closed)

Created:
3 years, 12 months ago by gsathya
Modified:
3 years, 12 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix SealHandleScope usage in runtime calls R=adamk@chromium.org BUG=v8:5783 Review-Url: https://codereview.chromium.org/2608433002 Cr-Commit-Position: refs/heads/master@{#41964} Committed: https://chromium.googlesource.com/v8/v8/+/9c9f1870df04c09c7fa57e1fd413e32a53667f68

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/runtime/runtime-promise.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
gsathya
3 years, 12 months ago (2016-12-27 18:44:13 UTC) #4
adamk
lgtm
3 years, 12 months ago (2016-12-27 19:04:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608433002/1
3 years, 12 months ago (2016-12-27 19:06:29 UTC) #9
commit-bot: I haz the power
3 years, 12 months ago (2016-12-27 19:08:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9c9f1870df04c09c7fa57e1fd413e32a536...

Powered by Google App Engine
This is Rietveld 408576698