Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 2608403002: Add some perf tests to compare Mojo overhead. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some perf tests to compare Mojo overhead. Specifically, this compares making mojo interface calls vs just sending raw IPC::Messages or callbacks. Review-Url: https://codereview.chromium.org/2608403002 Cr-Commit-Position: refs/heads/master@{#442016} Committed: https://chromium.googlesource.com/chromium/src/+/ca86c9e8f039783ad8b5f255995cb79b2a7287bf

Patch Set 1 : remove unnecessary base classes to simplify first #

Patch Set 2 : add mojo and callback versions #

Total comments: 2

Patch Set 3 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -529 lines) Patch
M ipc/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_mojo_perftest.cc View 1 3 chunks +601 lines, -28 lines 0 comments Download
D ipc/ipc_perftest_support.h View 1 chunk +0 lines, -99 lines 0 comments Download
D ipc/ipc_perftest_support.cc View 1 chunk +0 lines, -396 lines 0 comments Download
M ipc/ipc_test.mojom View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/run_all_perftests.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/edk/test/run_all_perftests.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 29 (24 generated)
jam
3 years, 11 months ago (2017-01-06 00:57:22 UTC) #21
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/2608403002/diff/60001/ipc/run_all_perftests.cc File ipc/run_all_perftests.cc (right): https://codereview.chromium.org/2608403002/diff/60001/ipc/run_all_perftests.cc#newcode21 ipc/run_all_perftests.cc:21: // loop, which is destructed inside base::LaunchUnitTests. This ...
3 years, 11 months ago (2017-01-06 18:15:07 UTC) #22
jam
https://codereview.chromium.org/2608403002/diff/60001/ipc/run_all_perftests.cc File ipc/run_all_perftests.cc (right): https://codereview.chromium.org/2608403002/diff/60001/ipc/run_all_perftests.cc#newcode21 ipc/run_all_perftests.cc:21: // loop, which is destructed inside base::LaunchUnitTests. On 2017/01/06 ...
3 years, 11 months ago (2017-01-06 18:24:18 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608403002/80001
3 years, 11 months ago (2017-01-06 18:26:57 UTC) #26
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 19:56:39 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ca86c9e8f039783ad8b5f255995c...

Powered by Google App Engine
This is Rietveld 408576698