PreParsing inner funcs: Do fewer variable name lookups.

PreParsing inner funcs: Do fewer variable name lookups.

It's unnecessarily to first lookup and then insert.

BUG=v8:5501
Review-Url: https://codereview.chromium.org/2608333003
Cr-Commit-Position: refs/heads/master@{#42065}
Committed: https://chromium.googlesource.com/v8/v8/+/11d13027e8c68b5406c85f08390586e49e4c42f9

[marja, 2017-01-04 10:28:47]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 10:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-01-04 10:42:34]

marja@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[marja, 2017-01-04 10:42:35]

ptal

[marja, 2017-01-04 10:42:47]

Description was changed from

==========
PreParsing inner funcs: Do less variable name lookups.

It's unnecessarily to first lookup and then insert.

BUG=v8:5501
==========

to

==========
PreParsing inner funcs: Do fewer variable name lookups.

It's unnecessarily to first lookup and then insert.

BUG=v8:5501
==========

[jochen (gone - plz use gerrit), 2017-01-04 10:51:13]

https://codereview.chromium.org/2608333003/diff/40001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2608333003/diff/40001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:56: void VariableMap::LookupOrDeclareName(Zone* zone, const
AstRawString* name) {
LookupOrDeclare sounds strange, as the method doesn't really do an observable
lookup?

[marja, 2017-01-04 10:52:12]

On 2017/01/04 10:51:13, jochen wrote:
> https://codereview.chromium.org/2608333003/diff/40001/src/ast/scopes.cc
> File src/ast/scopes.cc (right):
> 
>
https://codereview.chromium.org/2608333003/diff/40001/src/ast/scopes.cc#newco...
> src/ast/scopes.cc:56: void VariableMap::LookupOrDeclareName(Zone* zone, const
> AstRawString* name) {
> LookupOrDeclare sounds strange, as the method doesn't really do an observable
> lookup?

How about just DeclareName in that case then?

[jochen (gone - plz use gerrit), 2017-01-04 10:55:57]

that would lgtm

[marja, 2017-01-04 11:31:46]

I see what you did there

https://codereview.chromium.org/2608333003/diff/40001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2608333003/diff/40001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:56: void VariableMap::LookupOrDeclareName(Zone* zone, const
AstRawString* name) {
On 2017/01/04 10:51:13, jochen wrote:
> LookupOrDeclare sounds strange, as the method doesn't really do an observable
> lookup?

Done.

[marja, 2017-01-04 11:32:16]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-04 11:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2608333003/#ps60001
(title: "code review (jochen@)")

[commit-bot: I haz the power, 2017-01-04 11:32:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 11:58:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483529536062290,
"parent_rev": "fcffcba72581ea338e13f79f57df758449093179", "commit_rev":
"11d13027e8c68b5406c85f08390586e49e4c42f9"}

[commit-bot: I haz the power, 2017-01-04 11:58:24]

Description was changed from

==========
PreParsing inner funcs: Do fewer variable name lookups.

It's unnecessarily to first lookup and then insert.

BUG=v8:5501
==========

to

==========
PreParsing inner funcs: Do fewer variable name lookups.

It's unnecessarily to first lookup and then insert.

BUG=v8:5501

Review-Url: https://codereview.chromium.org/2608333003
Cr-Commit-Position: refs/heads/master@{#42065}
Committed:
https://chromium.googlesource.com/v8/v8/+/11d13027e8c68b5406c85f08390586e49e4...
==========

[commit-bot: I haz the power, 2017-01-04 11:58:25]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/11d13027e8c68b5406c85f08390586e49e4...