[cleanup] remove sloppy generator/async function maps

[cleanup] remove sloppy generator/async function maps

These maps contain exactly the same information as the strict maps, so
this frees up a few pointers of native context space, gets rid of some
branches in FastNewClosure, and adds missing poisoned properties tests
for async functions.

BUG=v8:2355, v8:4483
R=adamk@chromium.org, bmeurer@chromium.org, littledan@chromium.org

Review-Url: https://codereview.chromium.org/2608333002
Cr-Commit-Position: refs/heads/master@{#42051}
Committed: https://chromium.googlesource.com/v8/v8/+/c523474713e11e98f0b87f2d7137cf3465aab13c

[caitp, 2017-01-03 18:58:18]

The CQ bit was checked by caitp@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 18:58:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 19:01:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 19:01:59]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18547)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14962)

[caitp, 2017-01-03 19:48:33]

The CQ bit was checked by caitp@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 19:48:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caitp, 2017-01-03 20:18:12]

ptal --- some cleanup I've been wanting to land for a while. As far as I can
tell, this should be safe as there aren't any real differences between the
strict and sloppy variants.

[commit-bot: I haz the power, 2017-01-03 20:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 20:18:13]

Dry run: This issue passed the CQ dry run.

[adamk, 2017-01-03 20:55:41]

lgtm % nit

Some git archaeology suggests that these have been duplicated since
https://codereview.chromium.org/1027283004

https://codereview.chromium.org/2608333002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2608333002/diff/20001/src/bootstrapper.cc#new...
src/bootstrapper.cc:784: Map::Copy(strict_function_map, "StrictAsyncFunction");
No need for the "Strict" prefix here either.

[caitp, 2017-01-03 21:12:05]

On 2017/01/03 20:55:41, adamk wrote:
> lgtm % nit
> 
> Some git archaeology suggests that these have been duplicated since
> https://codereview.chromium.org/1027283004

I believe at the time, it actually was necessary to have the two maps, but this
has since become redundant.

https://codereview.chromium.org/2608333002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2608333002/diff/20001/src/bootstrapper.cc#new...
src/bootstrapper.cc:784: Map::Copy(strict_function_map, "StrictAsyncFunction");
On 2017/01/03 20:55:41, adamk wrote:
> No need for the "Strict" prefix here either.

Done

[caitp, 2017-01-03 21:12:10]

The CQ bit was checked by caitp@igalia.com

[caitp, 2017-01-03 21:12:11]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2608333002/#ps40001
(title: "[cleanup] remove sloppy generator/async function maps")

[commit-bot: I haz the power, 2017-01-03 21:12:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 21:38:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483477930957530,
"parent_rev": "410606a09d03b0bad3ef3eeea3beddfc32306325", "commit_rev":
"c523474713e11e98f0b87f2d7137cf3465aab13c"}

[commit-bot: I haz the power, 2017-01-03 21:38:27]

Description was changed from

==========
[cleanup] remove sloppy generator/async function maps

These maps contain exactly the same information as the strict maps, so
this frees up a few pointers of native context space, gets rid of some
branches in FastNewClosure, and adds missing poisoned properties tests
for async functions.

BUG=v8:2355, v8:4483
R=adamk@chromium.org, bmeurer@chromium.org, littledan@chromium.org
==========

to

==========
[cleanup] remove sloppy generator/async function maps

These maps contain exactly the same information as the strict maps, so
this frees up a few pointers of native context space, gets rid of some
branches in FastNewClosure, and adds missing poisoned properties tests
for async functions.

BUG=v8:2355, v8:4483
R=adamk@chromium.org, bmeurer@chromium.org, littledan@chromium.org

Review-Url: https://codereview.chromium.org/2608333002
Cr-Commit-Position: refs/heads/master@{#42051}
Committed:
https://chromium.googlesource.com/v8/v8/+/c523474713e11e98f0b87f2d7137cf3465a...
==========

[commit-bot: I haz the power, 2017-01-03 21:38:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/c523474713e11e98f0b87f2d7137cf3465a...

[Benedikt Meurer, 2017-01-04 04:57:01]

Awesome, LGTM!