Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2608283002: PPC/s390: [ic] Use StrictEqual/Equal builtins for CompareIC slow path. (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [ic] Use StrictEqual/Equal builtins for CompareIC slow path. Port d3ed71ed87426046afe8938592588eeaa92ec7a9 Original Commit Message: Don't fallback to the %StrictEqual / %Equal runtime functions for the generic CompareIC slow path, but use the (new) StrictEqual and Equal builtins instead. This avoids a performance cliff when mixing input types for strict equality sites. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4773 LOG=N Review-Url: https://codereview.chromium.org/2608283002 Cr-Commit-Position: refs/heads/master@{#42039} Committed: https://chromium.googlesource.com/v8/v8/+/dc4586ce0c79525c4ce5aa55204ec6d6812af551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-03 16:07:49 UTC) #1
JoranSiu
On 2017/01/03 16:07:49, JaideepBajwa wrote: > ptal lgtm
3 years, 11 months ago (2017-01-03 16:08:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608283002/1
3 years, 11 months ago (2017-01-03 16:14:26 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 16:59:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dc4586ce0c79525c4ce5aa55204ec6d6812...

Powered by Google App Engine
This is Rietveld 408576698