Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2608243005: Fix building simple_fuzzer with v8_static_library (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix building simple_fuzzer with v8_static_library We can't have "main" in a static library. so just include the small fuzzer.cc in all simple fuzzers BUG=none R=machenbach@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2608243005 Cr-Commit-Position: refs/heads/master@{#42086} Committed: https://chromium.googlesource.com/v8/v8/+/4692d96f744c5d4a4e9029ddeae2f0d31a14459c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M BUILD.gn View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jochen (gone - plz use gerrit)
ptal
3 years, 11 months ago (2017-01-05 07:15:24 UTC) #5
vogelheim
lgtm
3 years, 11 months ago (2017-01-05 09:22:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608243005/1
3 years, 11 months ago (2017-01-05 09:25:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/4692d96f744c5d4a4e9029ddeae2f0d31a14459c
3 years, 11 months ago (2017-01-05 09:27:44 UTC) #11
Michael Achenbach
3 years, 11 months ago (2017-01-09 08:13:31 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698