Make FTP directory parser less strict

net/ftp/ftp_directory_listing_parser.cc

Index: net/ftp/ftp_directory_listing_parser.cc
diff --git a/net/ftp/ftp_directory_listing_parser.cc b/net/ftp/ftp_directory_listing_parser.cc
index 151c1b9df56ea4a1f17d9c7294be0fdd8dbf32fb..06ecaa7850dd624698035104711ff1883979860c 100644
--- a/net/ftp/ftp_directory_listing_parser.cc
+++ b/net/ftp/ftp_directory_listing_parser.cc
@@ -91,7 +91,7 @@ int DecodeAndParse(const std::string& text,
 
   base::string16 converted_text;
   if (base::CodepageToUTF16(text, encoding_name,
-                            base::OnStringConversionError::FAIL,
+                            base::OnStringConversionError::SKIP,

[mmenke, 2017/01/05 00:20:53]

Would SUBSTITUTE be better, so we display a character that's more obviously
wrong, rather than a file name that just mysteriously can't be downloaded, for
unclear reasons?

[Jinsuk Kim, 2017/01/05 00:25:39]

Tried this but then the processing in |ParseListing| below fails. I stopped
there rather than debugging it further. Probably it doesn't like the replaced
char. 

In whichever case the file cannot be downloaded because it got different from
the original name that has broken chars.

[Jinsuk Kim, 2017/01/05 00:45:28]

Your feedback got me to look into it further... SUBSTITUTE option works if
another conversion used in |FillInRawName| also uses SUBSTITUTE. This looks
better as you pointed out, by making the broken character more obvious. Will
update accordingly. Thanks.

                             &converted_text)) {
     const char* const kNewlineSeparators[] = {"\n", "\r\n"};