Make FTP directory parser less strict

net/ftp/ftp_directory_listing_parser.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_directory_listing_parser.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/i18n/encoding_detection.h"
 #include "base/i18n/icu_string_conversions.h"
@@ skipping 73 matching lines @@
                    const base::Time& current_time,
                    std::vector<FtpDirectoryListingEntry>* entries,
                    FtpServerType* server_type) {
   std::string encoding;
   if (!base::DetectEncoding(text, &encoding))
     return ERR_ENCODING_DETECTION_FAILED;
   const char* encoding_name = encoding.c_str();
 
   base::string16 converted_text;
   if (base::CodepageToUTF16(text, encoding_name,
-                            base::OnStringConversionError::FAIL,
+                            base::OnStringConversionError::SKIP,

[mmenke, 2017/01/05 00:20:53]

Would SUBSTITUTE be better, so we display a character that's more obviously
wrong, rather than a file name that just mysteriously can't be downloaded, for
unclear reasons?

[Jinsuk Kim, 2017/01/05 00:25:39]

Tried this but then the processing in |ParseListing| below fails. I stopped
there rather than debugging it further. Probably it doesn't like the replaced
char. 

In whichever case the file cannot be downloaded because it got different from
the original name that has broken chars.

[Jinsuk Kim, 2017/01/05 00:45:28]

Your feedback got me to look into it further... SUBSTITUTE option works if
another conversion used in |FillInRawName| also uses SUBSTITUTE. This looks
better as you pointed out, by making the broken character more obvious. Will
update accordingly. Thanks.

                             &converted_text)) {
     const char* const kNewlineSeparators[] = {"\n", "\r\n"};
 
     for (size_t j = 0; j < arraysize(kNewlineSeparators); j++) {
       int rv = ParseListing(converted_text,
                             base::ASCIIToUTF16(kNewlineSeparators[j]),
                             encoding_name, current_time, entries, server_type);
       if (rv == OK)
         return rv;
     }
@@ skipping 14 matching lines @@
 int ParseFtpDirectoryListing(const std::string& text,
                              const base::Time& current_time,
                              std::vector<FtpDirectoryListingEntry>* entries) {
   FtpServerType server_type = SERVER_UNKNOWN;
   int rv = DecodeAndParse(text, current_time, entries, &server_type);
   UpdateFtpServerTypeHistograms(server_type);
   return rv;
 }
 
 }  // namespace net