Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2608203002: X87: [stubs] Port FastNewObjectStub to TF. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
chunyang.dai, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Port FastNewObjectStub to TF. port 5b02a98bfada37eafe94373e3fed1e11318d9a27 (r41986) original commit message: In the process, convert from a code stub into a builtin. BUG= Review-Url: https://codereview.chromium.org/2608203002 Cr-Commit-Position: refs/heads/master@{#42018} Committed: https://chromium.googlesource.com/v8/v8/+/0522ea7424efab83aa825c323582843a59d1d137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -140 lines) Patch
M src/builtins/x87/builtins-x87.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-03 03:52:08 UTC) #2
chunyang.dai
On 2017/01/03 03:52:08, zhengxing.li wrote: > PTAL, thanks! LGTM thanks
3 years, 11 months ago (2017-01-03 05:06:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608203002/1
3 years, 11 months ago (2017-01-03 05:36:01 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 06:01:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0522ea7424efab83aa825c323582843a59d...

Powered by Google App Engine
This is Rietveld 408576698