Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2608173002: Remove unused parts of //mojo/common. (Closed)

Created:
3 years, 11 months ago by Sam McNally
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused parts of //mojo/common. BUG=608017 Committed: https://crrev.com/23ffd510d988a0f266f30fb8ccdf70cbc77da1e9 Cr-Commit-Position: refs/heads/master@{#441228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -205 lines) Patch
M mojo/common/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/common/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/common/data_pipe_file_utils.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M mojo/common/data_pipe_utils.h View 2 chunks +4 lines, -32 lines 0 comments Download
M mojo/common/data_pipe_utils.cc View 3 chunks +2 lines, -34 lines 0 comments Download
D mojo/common/user_agent.h View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/common/user_agent.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Sam McNally
3 years, 11 months ago (2017-01-03 00:46:12 UTC) #4
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-03 20:25:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608173002/1
3 years, 11 months ago (2017-01-03 22:40:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 22:45:34 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 22:47:36 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23ffd510d988a0f266f30fb8ccdf70cbc77da1e9
Cr-Commit-Position: refs/heads/master@{#441228}

Powered by Google App Engine
This is Rietveld 408576698