Issue 2608163002: Deflake network-disable-cache-preloads

Yoav Weiss

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

3 years, 11 months ago (2017-01-02 15:56:48 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608163002/1

3 years, 11 months ago (2017-01-02 15:56:52 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 11 months ago (2017-01-02 15:58:22 UTC) #3

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/129136) ios-device-xcode-clang on ...

3 years, 11 months ago (2017-01-02 15:58:22 UTC) #4

Yoav Weiss

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

3 years, 11 months ago (2017-01-02 16:05:54 UTC) #5

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608163002/20001

3 years, 11 months ago (2017-01-02 16:05:57 UTC) #6

Yoav Weiss

Description was changed from ========== Deflake network-disable-cache-preloads BUG=652187 ========== to ========== Deflake network-disable-cache-preloads The test ...

3 years, 11 months ago (2017-01-02 16:11:59 UTC) #7

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 11 months ago (2017-01-02 17:14:32 UTC) #8

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/356711)

3 years, 11 months ago (2017-01-02 17:14:33 UTC) #9

Yoav Weiss

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

3 years, 11 months ago (2017-01-03 08:12:30 UTC) #10

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608163002/40001

3 years, 11 months ago (2017-01-03 08:12:36 UTC) #11

Yoav Weiss

yoav@yoav.ws changed reviewers: + csharrison@chromium.org

3 years, 11 months ago (2017-01-03 08:41:25 UTC) #12

Yoav Weiss

Hey Charlie, A small deflaking of a test we added to make sure devtools don't ...

3 years, 11 months ago (2017-01-03 08:41:26 UTC) #13

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 11 months ago (2017-01-03 09:12:21 UTC) #14

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

3 years, 11 months ago (2017-01-03 09:12:22 UTC) #15

Charlie Harrison

https://codereview.chromium.org/2608163002/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-preloads.php File third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-preloads.php (right): https://codereview.chromium.org/2608163002/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-preloads.php#newcode67 third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-preloads.php:67: <body onload="runTest(true)"> Does "true" force this to be a ...

3 years, 11 months ago (2017-01-03 14:47:46 UTC) #16

Yoav Weiss

https://codereview.chromium.org/2608163002/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-preloads.php File third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-preloads.php (right): https://codereview.chromium.org/2608163002/diff/40001/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-preloads.php#newcode67 third_party/WebKit/LayoutTests/http/tests/inspector/network/network-disable-cache-preloads.php:67: <body onload="runTest(true)"> On 2017/01/03 14:47:45, Charlie Harrison wrote: > ...

3 years, 11 months ago (2017-01-03 14:54:46 UTC) #17

Charlie Harrison

Ah, thanks for the additional info. LGTM this seems fine.

3 years, 11 months ago (2017-01-03 14:55:52 UTC) #18

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608163002/40001

3 years, 11 months ago (2017-01-03 15:04:40 UTC) #20

commit-bot: I haz the power

CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483455868344090, "parent_rev": "00add0772b1d9d3f93ec5ea3e6bc283b9b3a38e6", "commit_rev": "65d4c3bf94ae33da224b6bda7a225563a1490a9f"}

3 years, 11 months ago (2017-01-03 15:08:04 UTC) #21

commit-bot: I haz the power

Description was changed from ========== Deflake network-disable-cache-preloads The test was flaky due to its use ...

3 years, 11 months ago (2017-01-03 15:08:28 UTC) #22

commit-bot: I haz the power

Description was changed from ========== Deflake network-disable-cache-preloads The test was flaky due to its use ...

3 years, 11 months ago (2017-01-03 15:10:10 UTC) #24

commit-bot: I haz the power

3 years, 11 months ago (2017-01-03 15:10:11 UTC) #25

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/5a1b7255488614f897206baaee7f537b0b99e41d
Cr-Commit-Position: refs/heads/master@{#441124}

Issue 2608163002: Deflake network-disable-cache-preloads (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fixed test #

Messages