Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2608143003: [builtins] Migrate more Date builtins to TurboFan builtins. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate more Date builtins to TurboFan builtins. Migrate Date.prototype.valueOf and Date.prototype[ @@toPrimitive ] to use the CodeStubAssembler, to avoid going through C++ always when comparing or subtracting two dates. R=epertoso@chromium.org Review-Url: https://codereview.chromium.org/2608143003 Cr-Commit-Position: refs/heads/master@{#42030} Committed: https://chromium.googlesource.com/v8/v8/+/3a81236f4a6b4215fcad4460457921d2f3aaf186

Patch Set 1 #

Patch Set 2 : Fix invalid @@toPrimitive. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -44 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/builtins/builtins-date.cc View 1 3 chunks +92 lines, -16 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-03 12:29:55 UTC) #1
Benedikt Meurer
Hey Enrico, Here's an easy one that was sitting on my computer for some time. ...
3 years, 11 months ago (2017-01-03 12:30:35 UTC) #4
epertoso
lgtm
3 years, 11 months ago (2017-01-03 13:20:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608143003/20001
3 years, 11 months ago (2017-01-03 13:27:43 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 13:35:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/3a81236f4a6b4215fcad4460457921d2f3a...

Powered by Google App Engine
This is Rietveld 408576698