Refactor BackendHelpers to make 'find' methods private.

Refactor BackendHelpers to make 'find' methods private.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/1758a9c118395bac6373a2f169df36355a27cd41

[Johnni Winther, 2017-01-02 15:03:29]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-01-03 10:03:30]

ping

[Siggi Cherem (dart-lang), 2017-01-03 17:05:37]

lgtm

https://codereview.chromium.org/2608143002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart (right):

https://codereview.chromium.org/2608143002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart:24:
backend.helpers.jsHelperLibrary.find(name), callStructure);
maybe add a TODO about fixing this one too?

It seems like you are trying to hide all the name manipulations inside backend
helpers, so eventually that would mean to change things a bit with how the
checkedModeHelpers are created? I'm guessing we would probably provide the
entity rather than the name, and move something like
`getCheckedModeHelperNameInternal` into the backend helpers?

https://codereview.chromium.org/2608143002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2608143002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:3099: return js.js('(void 0).dummy');
could mock up tests be relying on the old name here? Or is this not used at all?
(If so, maybe we can get rid of the null check entirely?)

[Johnni Winther, 2017-01-04 10:10:57]

https://codereview.chromium.org/2608143002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart (right):

https://codereview.chromium.org/2608143002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart:24:
backend.helpers.jsHelperLibrary.find(name), callStructure);
On 2017/01/03 17:05:37, Siggi Cherem (dart-lang) wrote:
> maybe add a TODO about fixing this one too?
> 
> It seems like you are trying to hide all the name manipulations inside backend
> helpers, so eventually that would mean to change things a bit with how the
> checkedModeHelpers are created? I'm guessing we would probably provide the
> entity rather than the name, and move something like
> `getCheckedModeHelperNameInternal` into the backend helpers?

Added a TODO. What we really need is to only create (and enqueue) this on need
instead of brute force. These should be created due to BackendFeatures.

https://codereview.chromium.org/2608143002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2608143002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:3099: return js.js('(void 0).dummy');
On 2017/01/03 17:05:37, Siggi Cherem (dart-lang) wrote:
> could mock up tests be relying on the old name here? Or is this not used at
all?
> (If so, maybe we can get rid of the null check entirely?)

They seem not to. I think we just need a dummy property access to avoid a crash
when creating a static use below. I'm not sure if there is a good reason for the
mock library _not_ to support these helpers in the first place.

[Johnni Winther, 2017-01-04 10:25:55]

Description was changed from

==========
Refactor BackendHelpers to make 'find' methods private.
==========

to

==========
Refactor BackendHelpers to make 'find' methods private.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1758a9c118395bac6373a2f169df36355a27cd41
==========

[Johnni Winther, 2017-01-04 10:25:56]

Committed patchset #3 (id:40001) manually as
1758a9c118395bac6373a2f169df36355a27cd41 (presubmit successful).