Refactor BackendHelpers to make 'find' methods private.

pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import '../compiler.dart' show Compiler;
 import '../dart_types.dart';
 import '../elements/elements.dart';
 import '../js/js.dart' as jsAst;
 import '../js/js.dart' show js;
 import '../ssa/codegen.dart' show SsaCodeGenerator;
 import '../ssa/nodes.dart' show HTypeConversion;
 import '../universe/call_structure.dart' show CallStructure;
 import '../universe/use.dart' show StaticUse;
 import 'backend.dart';
 
 class CheckedModeHelper {
   final String name;
 
   const CheckedModeHelper(String this.name);
 
   StaticUse getStaticUse(Compiler compiler) {
     JavaScriptBackend backend = compiler.backend;
     return new StaticUse.staticInvoke(
-        backend.helpers.findHelper(name), callStructure);
+        backend.helpers.jsHelperLibrary.find(name), callStructure);

[Siggi Cherem (dart-lang), 2017/01/03 17:05:37]

maybe add a TODO about fixing this one too?

It seems like you are trying to hide all the name manipulations inside backend
helpers, so eventually that would mean to change things a bit with how the
checkedModeHelpers are created? I'm guessing we would probably provide the
entity rather than the name, and move something like
`getCheckedModeHelperNameInternal` into the backend helpers?

[Johnni Winther, 2017/01/04 10:10:57]

Added a TODO. What we really need is to only create (and enqueue) this on need
instead of brute force. These should be created due to BackendFeatures.

   }
 
   CallStructure get callStructure => CallStructure.ONE_ARG;
 
   jsAst.Expression generateCall(
       SsaCodeGenerator codegen, HTypeConversion node) {
     StaticUse staticUse = getStaticUse(codegen.compiler);
     codegen.registry.registerStaticUse(staticUse);
     List<jsAst.Expression> arguments = <jsAst.Expression>[];
     codegen.use(node.checkedInput);
@@ skipping 96 matching lines @@
     DartType type = node.typeExpression;
     Element element = type.element;
     jsAst.Name isField = codegen.backend.namer.operatorIs(element);
     arguments.add(js.quoteName(isField));
     codegen.use(node.typeRepresentation);
     arguments.add(codegen.pop());
     jsAst.Name asField = codegen.backend.namer.substitutionName(element);
     arguments.add(js.quoteName(asField));
   }
 }