Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2608113002: WorkerGlobalScope: verify same-heap event listeners. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
haraken, keishi
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WorkerGlobalScope: verify same-heap event listeners. To help narrow down failures during tracing of a WorkerGlobalScope's event listeners, verify that the listeners added belong to the same heap as the WorkerGlobalScope itself. R= BUG=677654 Committed: https://crrev.com/8efd8e095786c629795643083dd047d643315f17 Cr-Commit-Position: refs/heads/master@{#441058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-02 10:32:13 UTC) #4
haraken
LGTM, thanks
3 years, 11 months ago (2017-01-02 10:42:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608113002/1
3 years, 11 months ago (2017-01-02 12:01:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-02 12:05:52 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:55:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8efd8e095786c629795643083dd047d643315f17
Cr-Commit-Position: refs/heads/master@{#441058}

Powered by Google App Engine
This is Rietveld 408576698