Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2608073002:
[GeometryInterface] enable Exposed keyword at DOMMatrix*.idl. (Closed)
|
Created:
3 years, 11 months ago by Hwanseung Lee Modified:
3 years, 11 months ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[GeometryInterface] enable Exposed keyword at DOMMatrix*.idl.
BUG=388780
Review-Url: https://codereview.chromium.org/2608073002
Cr-Commit-Position: refs/heads/master@{#443060}
Committed: https://chromium.googlesource.com/chromium/src/+/0b469432cc5bd5db8422ce5a8100f8fcae148a2c
Patch Set 1 #Patch Set 2 : [GeometryInterface] enable Exposed keyword at DOMMatrix*.idl. #Patch Set 3 : [GeometryInterface] enable Exposed keyword at DOMMatrix*.idl. #Messages
Total messages: 42 (33 generated)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [GeometryInterface] enable Exposed keyword at DOMMatrix*.idl. BUG=388780 ========== to ========== [GeometryInterface] enable Exposed keyword at DOMMatrix*.idl. BUG=388780 ==========
hs1217.lee@samsung.com changed reviewers: + dominicc@chromium.org, jinho.bang@samsung.com
@dominicc, zino PTAL, thank you.
lgtm (For reviewer, this feature is still behind runtime flag. So, no need a intent.)
The CQ bit was checked by dominicc@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by hs1217.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hs1217.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 30005, "attempt_start_ts": 1484178258183760,
"parent_rev": "3418f524d88d8851f26ea6a9ea0ac04cf6aea332", "commit_rev":
"0b469432cc5bd5db8422ce5a8100f8fcae148a2c"}
Message was sent while issue was closed.
Description was changed from ========== [GeometryInterface] enable Exposed keyword at DOMMatrix*.idl. BUG=388780 ========== to ========== [GeometryInterface] enable Exposed keyword at DOMMatrix*.idl. BUG=388780 Review-Url: https://codereview.chromium.org/2608073002 Cr-Commit-Position: refs/heads/master@{#443060} Committed: https://chromium.googlesource.com/chromium/src/+/0b469432cc5bd5db8422ce5a8100... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:30005) as https://chromium.googlesource.com/chromium/src/+/0b469432cc5bd5db8422ce5a8100... |
